Docs for presence - #132
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| new Application({ | ||
| servicers: [MyServicer], | ||
| libraries: [presenceLibrary()] |
There was a problem hiding this comment.
Bug: missing comma after libraries: [presenceLibrary()]. Since ASI doesn't apply inside an object literal, copy-pasting this snippet produces a SyntaxError at initialize. The Python tab just above uses libraries=[presence_library()], and the two later TypeScript snippets in this file both have the comma, so this looks like a typo.
| libraries: [presenceLibrary()] | |
| libraries: [presenceLibrary()], |
| * `presenceId` is the `string` ID of the `Presence` instance you want to track | ||
| the subscriber for. |
There was a problem hiding this comment.
Bug: the prop is named id, not presenceId. Under a heading that lists the component's props (and next to subscriberId, which is a real prop name), a reader will write <Presence presenceId={...}> and fail type-checking.
The component declares its props as:
reboot/reboot/std/react/presence/index.tsx
Lines 22 to 28 in 5e4b9b4
The example further down in this doc correctly passes the local variable presenceId to the id prop.
| * `presenceId` is the `string` ID of the `Presence` instance you want to track | |
| the subscriber for. | |
| * `id` is the `string` ID of the `Presence` instance you want to track | |
| the subscriber for. |
5e4b9b4 to
b6bcfaf
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
541b312 to
7954b41
Compare
* Change MouseArrow to not implicitly rely on tailwind. * Don't require children for MouseTracker
* Queue tests: comment fix * OrderedMap docs: fix broken link
* Fixed authorizer examples. * Test for subscriber connection in TS. * Subscriber full example code in docs. * Wording updates.
b6bcfaf to
cdb6cd6
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
1 participant
Uh oh!
There was an error while loading. Please reload this page.